[FFmpeg-devel] [PATCH] Implement NewTek NDI support

[Maksym Veremeyenko]

On 23.07.2017 15:43, Marton Balint wrote:
[...]
>> But I think it would be better if you tried to use AVThreadMessageQueue
>> instead. You can extend it if necessary.
>
> That is copied from decklink_dec as far as I see. Maybe better to
> factorize first, and move it to AVThreadMessageQueue as a second step?
exactlty


>>> +    { "wait_sources", "Time to wait until the number of online
>>> sources have changed (ms)"  , OFFSET(wait_sources), AV_OPT_TYPE_INT,
>>> { .i64 = 500 }, 100, 10000, DEC },
>>
>> AV_OPT_TYPE_DURATION
>
> Note: duration is microsec, not milisec, so code/docs needs updating as
> well.
ok

>
>
>>> +    }
>>> +    if (c->channels != 2 && c->channels != 4 && c->channels != 8) {
>>> +        av_log(avctx, AV_LOG_ERROR, "Unsupported number of channels!"
>>> +               " Only stereo and 7.1 are supported.\n");
>>
>> Check channel layout too.
>
> I think it is better if it works with unkown channel layouts as well, as
> long as the number of channels are supported.
ok


-- 
Maksym Veremeyenko