[FFmpeg-devel] [PATCH 1/4] Move lavd/v4l2-common.* to lavc

[Reimar Döffinger]

Hmm... a bit weird that we have a file with a dash in the file name when everything else uses underscore...


On 24.07.2017, at 21:08, Jorge Ramirez-Ortiz <jorge.ramirez-ortiz at linaro.org> wrote:

> From: Alexis Ballier <aballier at gentoo.org>
> 
> In preparation to support the integation of the V4L2 API for encoding
> and decoding, move v4l2 related files to libavcodec.
> 
[...]
> +extern const struct v4l_fmt_map avpriv_v4l_fmt_conversion_table[];
> 

Not sure it is even needed, but variables/arrays should never be exported outside the library they are in, not even with avpriv.
Admittedly this code should not be relevant for Windows where it would cause the worst problems, but it not good to export variables from a library on Linux either.