[FFmpeg-devel] [PATCH] avformat/oggparsecelt: Do not re-allocate os->private
Michael Niedermayer
michael at niedermayer.cc
Tue Jul 25 05:51:27 EEST 2017
Fixes: double free
Fixes: clusterfuzz-testcase-minimized-5080550145785856
Found-by: ClusterFuzz
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
libavformat/oggparsecelt.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavformat/oggparsecelt.c b/libavformat/oggparsecelt.c
index 6d567f988a..9c438a096a 100644
--- a/libavformat/oggparsecelt.c
+++ b/libavformat/oggparsecelt.c
@@ -65,9 +65,14 @@ static int celt_header(AVFormatContext *s, int idx)
st->codecpar->channels = nb_channels;
if (sample_rate)
avpriv_set_pts_info(st, 64, 1, sample_rate);
- priv->extra_headers_left = 1 + extra_headers;
- av_free(os->private);
+
+ if (os->private) {
+ av_free(priv);
+ priv = os->private;
+ }
os->private = priv;
+ priv->extra_headers_left = 1 + extra_headers;
+
AV_WL32(st->codecpar->extradata + 0, overlap);
AV_WL32(st->codecpar->extradata + 4, version);
return 1;
--
2.13.0
More information about the ffmpeg-devel
mailing list