[FFmpeg-devel] [PATCH 2/2] avformat/rtmppkt: Convert ff_amf_get_field_value() to bytestream2

James Almer jamrial at gmail.com
Sat Jul 29 05:15:47 EEST 2017


On 7/28/2017 10:57 PM, Michael Niedermayer wrote:
> On Fri, Jul 28, 2017 at 03:47:05PM +0200, Michael Niedermayer wrote:
>> Fixes: out of array accesses
>>
> 
>> The new function uses ff_ prefix even though its static to ease future
>> changes toward bytestream2
> 
> applied without this and also the ff_ prefix removed as requested
> for the other patch, so its consistent

I had actually not looked at this patch when i wrote that suggestion.

I'm not sure how the ff_ prefix would ease future changes to bytestream2
with a static function, but if you think it's worth doing then you can
keep it. It was mostly a nit.


More information about the ffmpeg-devel mailing list