[FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

[Thilo Borgmann]

Hi,

Am 28.07.17 um 11:34 schrieb sharpbai:
> From: sharpbai <tian.bai at duobei.com>
>
> feature: add scaleFactor attribute for avfoundation
> added by: siyuan.wang at duobei.com
> added by: yiren.li at duobei.com
> ---
>  doc/indevs.texi            | 3 +++
>  libavdevice/avfoundation.m | 6 ++++++
>  2 files changed, 9 insertions(+)
>
> diff --git a/doc/indevs.texi b/doc/indevs.texi
> index 09e3321..8873477 100644
> --- a/doc/indevs.texi
> +++ b/doc/indevs.texi
> @@ -139,6 +139,9 @@ Capture the mouse pointer. Default is 0.
>  @item -capture_mouse_clicks
>  Capture the screen mouse clicks. Default is 0.
>  
> + at item -scale_factor
> +Scale factor for capture the screen. Default is 1.
> +

the default is "1.0".


>  @end table
>  
>  [...]
>      { "capture_mouse_clicks", "capture the screen mouse clicks", offsetof(AVFContext, capture_mouse_clicks), AV_OPT_TYPE_INT, {.i64=0}, 0, 1, AV_OPT_FLAG_DECODING_PARAM },
> +    { "scale_factor", "scale screen factor range", offsetof(AVFContext, scale_factor), AV_OPT_TYPE_FLOAT, {.i64=1}, 0, 2, AV_OPT_FLAG_DECODING_PARAM },

Should initialized by "{.dbl=1.0}" like Moritz suggested.

Also, did you test with 0.0 < scale_factor < 1.0 values?
Why stop at factor 2.0? Did you test for scale_factor > 2.0?

Also please add this new option to the documentation. 

-Thilo