[FFmpeg-devel] [PATCH] vf_spp: only assign function pointers if permutation matches expectations.

[Ronald S. Bultje]

Hi,

On Thu, Jun 22, 2017 at 4:28 PM, Michael Niedermayer <michael at niedermayer.cc>
wrote:
> On Wed, Jun 21, 2017 at 09:03:11PM -0400, Ronald S. Bultje wrote:
> > On Wed, Jun 21, 2017 at 8:42 PM, Michael Niedermayer
<michael at niedermayer.cc
> > > also the memcmp() is a very ugly way to check the permutation
> >
> > Only thing that's possible through the API at this point, so I'm just
being
> > practical :-). I agree it'd be nice to extend the API to simplify these
> > type of checks, but I don't really like the idea of adding an enum to
> > AVDCT, too implementation-specific and static... Have better ideas?
>
> you can use an enum that uses some "revission number" or date-time
> of the first introduction of a permutation into the codebase.
> A string of the equation that creates the permutation is an option
> too. or some checksum/hash of the table.

I think we agreed on IRC that a checksum would be suitable here, so I've
used a CRC, I hope that's OK.

Ronald