[FFmpeg-devel] [PATCH] Added AVX2 implementation for VP8 decoder (ff_pred16x16_tm_vp8_8_avx2)

[James Almer]

On 3/12/2017 12:13 AM, Michael Niedermayer wrote:
> On Sun, Mar 12, 2017 at 12:35:01AM +0530, Mirage Abeysekara wrote:
>> ---
>>  libavcodec/x86/h264_intrapred.asm    | 35 +++++++++++++++++++++++++++++++++++
>>  libavcodec/x86/h264_intrapred_init.c |  7 +++++++
>>  2 files changed, 42 insertions(+)
>>
> 
> breaks build with nasm
> 
> src/libavcodec/x86/h264_intrapred.asm:275: error: parser: instruction expected
> src/libavcodec/x86/h264_intrapred.asm:281: error: symbol `vpbroadcastb' redefined
> src/libavcodec/x86/h264_intrapred.asm:281: error: parser: instruction expected
> src/libavcodec/x86/h264_intrapred.asm:282: error: symbol `vpbroadcastb' redefined
> src/libavcodec/x86/h264_intrapred.asm:282: error: parser: instruction expected
> src/libavcodec/x86/h264_intrapred.asm:283: error: symbol `vpbroadcastb' redefined
> src/libavcodec/x86/h264_intrapred.asm:283: error: parser: instruction expected
> src/libavcodec/x86/h264_intrapred.asm:284: error: symbol `vpbroadcastb' redefined
> src/libavcodec/x86/h264_intrapred.asm:284: error: parser: instruction expected
> src/libavcodec/x86/h264_intrapred.asm:295: error: parser: instruction expected
> src/libavcodec/x86/h264_intrapred.asm:296: error: symbol `vpermq' redefined
> src/libavcodec/x86/h264_intrapred.asm:296: error: parser: instruction expected
> src/libavcodec/x86/h264_intrapred.asm:298: error: parser: instruction expected
> src/libavcodec/x86/h264_intrapred.asm:300: error: symbol `vextracti128' redefined
> src/libavcodec/x86/h264_intrapred.asm:300: error: parser: instruction expected

What version? I suppose it's an old one not supporting AVX2.
It should be a matter of adding a HAVE_AVX2_EXTERNAL preprocessor
guard to the asm function.