[FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

[Ronald S. Bultje]

Hi,

On Wed, Mar 15, 2017 at 6:12 PM, Michael Niedermayer <michael at niedermayer.cc
> wrote:

> On Wed, Mar 15, 2017 at 07:18:30PM +0000, Kieran Kunhya wrote:
> > >
> > > > > I have tons of testcases for h264 that are 1KB and can make error
> > > > > concealment run for ages.
> > >
> > > and how is this related to a fix for th vp* decoder ?
> > >
> >
> > My point is you can spend a lifetime fixing obscure conditions that cause
> > error concealment to take a long time.
>
> the vp56 EC code
> just sets every block to the reference frames content


I don't see how this helps the user experience.

I once again think you should consider removing the vp56 EC code until we
have a better idea of requirements of and need for such a feature.

Ronald