[FFmpeg-devel] [PATCH 08/10] lavf/ape: remove unused magic field

[Michael Niedermayer]

On Mon, Mar 27, 2017 at 09:52:01AM +0200, Clément Bœsch wrote:
> ---
>  libavformat/ape.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/libavformat/ape.c b/libavformat/ape.c
> index 50a1aa13c1..c06db78480 100644
> --- a/libavformat/ape.c
> +++ b/libavformat/ape.c
> @@ -57,7 +57,6 @@ typedef struct APEContext {
>      APEFrame *frames;
>  
>      /* Info from Descriptor Block */
> -    char magic[4];
>      int16_t fileversion;
>      int16_t padding1;
>      uint32_t descriptorlength;
> @@ -102,7 +101,6 @@ static void ape_dumpinfo(AVFormatContext * s, APEContext * ape_ctx)
>      int i;
>  
>      av_log(s, AV_LOG_DEBUG, "Descriptor Block:\n\n");
> -    av_log(s, AV_LOG_DEBUG, "magic                = \"%c%c%c%c\"\n", ape_ctx->magic[0], ape_ctx->magic[1], ape_ctx->magic[2], ape_ctx->magic[3]);
>      av_log(s, AV_LOG_DEBUG, "fileversion          = %"PRId16"\n", ape_ctx->fileversion);
>      av_log(s, AV_LOG_DEBUG, "descriptorlength     = %"PRIu32"\n", ape_ctx->descriptorlength);
>      av_log(s, AV_LOG_DEBUG, "headerlength         = %"PRIu32"\n", ape_ctx->headerlength);

ok unless someone wants this to be fixed the other way around and
the field be printed

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170328/c843d7be/attachment.sig>