[FFmpeg-devel] [PATCH 2/2] libavformat/tests: Add http cookie tests cases to fate

[Michael Niedermayer]

On Tue, May 02, 2017 at 08:29:25PM -0400, Micah Galizia wrote:
> Signed-off-by: Micah Galizia <micahgalizia at gmail.com>
> ---
>  libavformat/Makefile       |   1 +
>  libavformat/tests/http.c   | 186 +++++++++++++++++++++++++++++++++++++++++++++
>  tests/fate/libavformat.mak |   5 ++
>  tests/ref/fate/http        |  30 ++++++++
>  4 files changed, 222 insertions(+)
>  create mode 100644 libavformat/tests/http.c
>  create mode 100644 tests/ref/fate/http

seems to crash here
vagrind shows these:

...

'good=not_expired; domain=.test.com; path=/; expires=Tue, 19 Jan 2038 03:14:07 GMT; HttpOnly'->'expires'|'Tue, 19 Jan 2038 03:14:07 GMT'
'good=great'->'good'|'great'
0) 'first="good"; Domain=.test.com; Path=/
second=great; domain=.test.com; path=/; HttpOnly'=>'first="good"; second=great'

==1192== Conditional jump or move depends on uninitialised value(s)
==1192==    at 0x5FECFD: av_log (log.c:372)
==1192==    by 0x4076C6: get_cookies (http.c:990)
==1192==    by 0x40A0FA: test_get_cookies (http.c:93)
==1192==    by 0x40A575: main (http.c:177)
==1192==
==1192== Conditional jump or move depends on uninitialised value(s)
==1192==    at 0x5FE5D4: format_line (log.c:258)
==1192==    by 0x5FE9B2: av_log_default_callback (log.c:324)
==1192==    by 0x5FEDA8: av_vlog (log.c:383)
==1192==    by 0x5FED68: av_log (log.c:375)
==1192==    by 0x4076C6: get_cookies (http.c:990)
==1192==    by 0x40A0FA: test_get_cookies (http.c:93)
==1192==    by 0x40A575: main (http.c:177)
==1192==
...
==1194== 46 (16 direct, 30 indirect) bytes in 1 blocks are definitely lost in loss record 158 of 238
==1194==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==1194==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==1194==    by 0x600F59: av_malloc (mem.c:87)
==1194==    by 0x6011EF: av_mallocz (mem.c:224)
==1194==    by 0x5F2600: av_dict_set (dict.c:89)
==1194==    by 0x40683E: parse_set_cookie (http.c:730)
==1194==    by 0x4068D1: parse_cookie (http.c:748)
==1194==    by 0x40A4B3: test_parse_cookie (http.c:159)
==1194==    by 0x40A585: main (http.c:181)
==1194==
==1194== 83 (16 direct, 67 indirect) bytes in 1 blocks are definitely lost in loss record 165 of 238
==1194==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==1194==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==1194==    by 0x600F59: av_malloc (mem.c:87)
==1194==    by 0x6011EF: av_mallocz (mem.c:224)
==1194==    by 0x5F2600: av_dict_set (dict.c:89)
==1194==    by 0x406BF6: parse_cookie (http.c:797)
==1194==    by 0x40A4B3: test_parse_cookie (http.c:159)
==1194==    by 0x40A585: main (http.c:181)
==1194==
==1194== 97 (16 direct, 81 indirect) bytes in 1 blocks are definitely lost in loss record 168 of 238
==1194==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==1194==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==1194==    by 0x600F59: av_malloc (mem.c:87)
==1194==    by 0x6011EF: av_mallocz (mem.c:224)
==1194==    by 0x5F2600: av_dict_set (dict.c:89)
==1194==    by 0x40683E: parse_set_cookie (http.c:730)
==1194==    by 0x4068D1: parse_cookie (http.c:748)
==1194==    by 0x40A39C: test_parse_cookie (http.c:145)
==1194==    by 0x40A585: main (http.c:181)
==1194==
==1194== 97 (16 direct, 81 indirect) bytes in 1 blocks are definitely lost in loss record 169 of 238
==1194==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==1194==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==1194==    by 0x600F59: av_malloc (mem.c:87)
==1194==    by 0x6011EF: av_mallocz (mem.c:224)
==1194==    by 0x5F2600: av_dict_set (dict.c:89)
==1194==    by 0x40683E: parse_set_cookie (http.c:730)
==1194==    by 0x4068D1: parse_cookie (http.c:748)
==1194==    by 0x40A50C: test_parse_cookie (http.c:163)
==1194==    by 0x40A585: main (http.c:181)
==1194==
==1194== 101 (16 direct, 85 indirect) bytes in 1 blocks are definitely lost in loss record 170 of 238
==1194==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==1194==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==1194==    by 0x600F59: av_malloc (mem.c:87)
==1194==    by 0x6011EF: av_mallocz (mem.c:224)
==1194==    by 0x5F2600: av_dict_set (dict.c:89)
==1194==    by 0x40683E: parse_set_cookie (http.c:730)
==1194==    by 0x4068D1: parse_cookie (http.c:748)
==1194==    by 0x40A44E: test_parse_cookie (http.c:154)
==1194==    by 0x40A585: main (http.c:181)
==1194==
==1194== 122 (16 direct, 106 indirect) bytes in 1 blocks are definitely lost in loss record 173 of 238
==1194==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==1194==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==1194==    by 0x600F59: av_malloc (mem.c:87)
==1194==    by 0x6011EF: av_mallocz (mem.c:224)
==1194==    by 0x5F2600: av_dict_set (dict.c:89)
==1194==    by 0x406BF6: parse_cookie (http.c:797)
==1194==    by 0x40769D: get_cookies (http.c:989)
==1194==    by 0x40A0FA: test_get_cookies (http.c:93)
==1194==    by 0x40A575: main (http.c:177)
==1194==
==1194== 1,330 (144 direct, 1,186 indirect) bytes in 9 blocks are definitely lost in loss record 219 of 238
==1194==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==1194==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==1194==    by 0x600F59: av_malloc (mem.c:87)
==1194==    by 0x6011EF: av_mallocz (mem.c:224)
==1194==    by 0x5F2600: av_dict_set (dict.c:89)
==1194==    by 0x40683E: parse_set_cookie (http.c:730)
==1194==    by 0x4076DC: get_cookies (http.c:993)
==1194==    by 0x40A0FA: test_get_cookies (http.c:93)
==1194==    by 0x40A575: main (http.c:177)
==1194==
==1194== 1,495 (160 direct, 1,335 indirect) bytes in 10 blocks are definitely lost in loss record 222 of 238
==1194==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==1194==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==1194==    by 0x600F59: av_malloc (mem.c:87)
==1194==    by 0x6011EF: av_mallocz (mem.c:224)
==1194==    by 0x5F2600: av_dict_set (dict.c:89)
==1194==    by 0x40683E: parse_set_cookie (http.c:730)
==1194==    by 0x4068D1: parse_cookie (http.c:748)
==1194==    by 0x40769D: get_cookies (http.c:989)
==1194==    by 0x40A0FA: test_get_cookies (http.c:93)
==1194==    by 0x40A575: main (http.c:177)
==1194==
==1194== 6,398 (104 direct, 6,294 indirect) bytes in 1 blocks are definitely lost in loss record 236 of 238
==1194==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==1194==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==1194==    by 0x600F59: av_malloc (mem.c:87)
==1194==    by 0x6011EF: av_mallocz (mem.c:224)
==1194==    by 0x40A704: url_alloc_for_protocol (avio.c:94)
==1194==    by 0x40B2BA: ffurl_alloc (avio.c:299)
==1194==    by 0x40A04E: test_get_cookies (http.c:84)
==1194==    by 0x40A575: main (http.c:177)
==1194==
==1194== LEAK SUMMARY:
==1194==    definitely lost: 504 bytes in 26 blocks
==1194==    indirectly lost: 9,265 bytes in 190 blocks
==1194==      possibly lost: 0 bytes in 0 blocks
==1194==    still reachable: 83,768 bytes in 2,707 blocks
==1194==         suppressed: 0 bytes in 0 blocks

[...9
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170503/50b4a92c/attachment.sig>