[FFmpeg-devel] [PATCH] fixes the issue https://trac.ffmpeg.org/ticket/6338

[Vineet Goel]

thank for you pointing it out. I'll go through the docs.
and for this patch do I have to redo as per norms, or is it accepted?

regards,
Vineet



On Thu, May 4, 2017 at 8:04 PM, Moritz Barsnick <barsnick at gmx.net> wrote:

> On Thu, May 04, 2017 at 08:04:21 +0530, Vineet Goel wrote:
> > sorry about that. I am not proficient with git and development.
>
> There are a lot of useful hints here:
> https://ffmpeg.org/developer.html
> Actually pretty much a must-read before submitting patches. ;-)
>
> > And I am attaching the patch file as is generated by "git format-patch
> > origin/master" command
>
> Fine.
>
> If you look at how other contributions to git look (it's worth taking
> the time!), you will see that the first line of your commit message
> should probably read:
>
> lavf/http: fix cookies with proxy
>
> followed by an empty line, and then something like
> "
> Fixes #6338.
> "
>
> Sorry for nitpicking and not actually reviewing the change, ;-)
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>