[FFmpeg-devel] [PATCH] avfilter: align data frame when needed

[Nicolas George]

Le sextidi 16 floréal, an CCXXV, Hendrik Leppkes a écrit :
> Blocking crash fixes on silly arguments doesn't help anyone. Send a
> doc update yourself or stop blocking valid crash fixes.
> Every ffmpeg developer knows that we have alignment requirements,
> trying to badger someone into writing docs and holding crash fixes
> hostage in the process is not the way to go.

Now that I have a little more time, let me elaborate.

When a patch fixes the obvious trigger of a bug without fixing the
actual cause, you are one of the first to object, even in strong terms.
And you are right.

Well, this instance is exactly a case like that. If the alignment
requirements are not documented, then an application can do things in a
way similar to take_samples() right now, and result in a crash. And
there is no blaming the application, it followed the documentation.

The bug is not in take_samples(), the bug is in all the filters and
codecs that require alignment without documenting it.

Therefore, the correct fix is to either change the filters to not
require the alignment, or to document it. The second option is obviously
the best.

Now, I will NOT do the documentation myself, for two reasons. First
because I do not know the code that requires alignment. Second, because
I am quite fed up with the attitude of a few developers here who
constantly bash their peers who undertake hard but necessary overhauls.

As is, this patch is rejected because it is unnecessary and wasteful,
and only hides the crash in it most obvious manifestation. This is not a
tantrum, this is proper development. I want a proper fix, and usually,
so do you.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170505/561f1048/attachment.sig>