[FFmpeg-devel] [PATCH] avio_read data loss with multiple calls to fill_buffer

Michael Niedermayer michael at niedermayer.cc
Fri May 19 22:16:18 EEST 2017


On Fri, May 19, 2017 at 08:28:23PM +0200, Michael Niedermayer wrote:
> hi
> 
> On Thu, May 18, 2017 at 10:58:39PM +0000, Rob Meyers wrote:
> > avio_read does multiple calls to fill_buffer(). Adjusting things in
> > fill_buffer was frowned upon; how would you suggest I approach this?
> 
> Its not frowned upon to fix a bug in fill_buffer(), its frowned
> upon to make a random change that fixes a testcase without fixing
> the underlaing bug.

> (there is a bug somewhere)

should be fixed

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170519/02bc5455/attachment.sig>


More information about the ffmpeg-devel mailing list