[FFmpeg-devel] mp4 encryption with time code track

[Michael Niedermayer]

On Wed, May 24, 2017 at 04:35:44PM +0000, Eran Kornblau wrote:
> Ping
> 
> Eran
> 
> From: Eran Kornblau
> Sent: Wednesday, May 17, 2017 12:50 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: mp4 encryption with time code track
> 
> Hi all,
> 
> We bumped into an issue with the mp4 encryption support we submitted a while ago -
> in case ffmpeg decides to write a timecode track in the output mp4, it crashes.
> The reason is that mov_create_timecode_track calls ff_mov_write_packet on a track that doesn't
> have 'cenc' initialized, this in turn causes a null dereference.
> The suggested fix is to change the 'if's that decide whether to encrypt to check whether 'cenc'
> was initialized, instead of checking whether some encryption scheme was set.
> 
> Patch attached
> 
> Thanks,
> 
> Eran

>  movenc.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> f79b25aee823f3ed2c5bdbb00103a16d42a97b99  0001-movenc-encryption-with-time-code-track-fix.patch
> From 21ae7625686057d145479304bb0a18de1e60f5b3 Mon Sep 17 00:00:00 2001
> From: erankor <eran.kornblau at kaltura.com>
> Date: Wed, 17 May 2017 12:32:06 +0300
> Subject: [PATCH] movenc: encryption with time code track fix
> 
> instead of deciding whether to encrypt based on the encryption scheme,
> decide according to whether cenc was initialized or not.
> mov_create_timecode_track calls ff_mov_write_packet with a track that
> doesn't have cenc initialized.

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170528/17797384/attachment.sig>