[FFmpeg-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

James Almer jamrial at gmail.com
Sat Nov 4 19:57:18 EET 2017


On 11/4/2017 2:52 PM, Derek Buitenhuis wrote:
> On 11/3/2017 6:23 PM, Kieran Kunhya wrote:
>> This patch fixes very high memory usage on pathological streams.
> 
> [...]
> 
>> -    H2645Packet pkt = { 0 };
>> +    H2645Packet pkt;
>> +    memset(&pkt, 0, sizeof(pkt));
> 
> Stray unrelated change.

Yed, it's both unnecessary and will raise a warning about mixed
declaration and code.

> 
> Rest seems reasonable from a cursory glance. I assume it's
> been run with ASAN or whatever + FATE, and valgrind.

I ran it with asan, using one and four threads. No reported failures or
leaks.

> 
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 



More information about the ffmpeg-devel mailing list