[FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

Moritz Barsnick barsnick at gmx.net
Sun Nov 5 21:10:58 EET 2017


On Sun, Nov 05, 2017 at 02:41:54 +0000, Mironov, Mikhail wrote:

> > > +    { "quality",        "", 0, AV_OPT_TYPE_CONST, { .i64 =
> > AMF_VIDEO_ENCODER_HEVC_QUALITY_PRESET_QUALITY  }, 0, 0, VE,
> > "quality" },
> > 
> > These are 0, 5, 10.  Do the intermediate values work?  Should they be
> > exposed?
> > 
> Only enum values are supported. I guess they left space for future extensions. 

What if an unsupported value is passed via AMF_ASSIGN_PROPERTY_INT64()?
Despite enumerated values, ffmpeg allows to pass numerical values, and
you don't verify that they are only 0, 5, 10.

Moritz


More information about the ffmpeg-devel mailing list