[FFmpeg-devel] FFplay: progress bar feature proposal
lingjiujianke at gmail.com
Mon Nov 6 05:36:56 EET 2017
2017-11-06 4:36 GMT+08:00 Michael Niedermayer <michael at niedermayer.cc>:
> On Thu, Apr 13, 2017 at 10:53:49AM -0500, Raymond Pierce wrote:
>> 13.04.2017, 09:40, "Steven Liu" <lingjiujianke at gmail.com>:
>> > 2017-04-13 20:48 GMT+08:00 Raymond Pierce <ray1110000 at yandex.com>:
>> >> Hi. Currently FFplay has no visible progress bar and it is hard to tell
>> >> where a stream is currently positioned. So if one wants, for example, to
>> >> rewind
>> >> a little back relative to current position using right mouse click it is
>> >> always
>> >> guessing and trying.
>> >> I propose very simple 1-pixel progress bar which can be turned on or off
>> >> during
>> >> playback by pressing a button (I use 'L', from 'line'). By default the bar
>> >> is off.
>> >> I choose bright green color (#00ff00) for the part to the left of a current
>> >> position and pure black for the part to the right.
>> >> You can see how it looks on the attached image.
>> >> Draft patch is applied. One global variable ('static int
>> >> show_progress_line')
>> >> and one function ('static void video_progress_line_display(VideoState
>> >> *is)')
>> >> have been added. Also the existing 'video_display()' function has been
>> >> moved
>> >> below 'get_master_clock()' as the latter is used in the new function.
>> >> What do you think?
>> >> _______________________________________________
>> >> ffmpeg-devel mailing list
>> >> ffmpeg-devel at ffmpeg.org
>> >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> > git commit -a
>> > git format-patch -s -1
>> > You should use the command looks like the above git command to make patch
>> > _______________________________________________
>> > ffmpeg-devel mailing list
>> > ffmpeg-devel at ffmpeg.org
>> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> Hello, Steven. Thank you for the advice. New patch in the attachment.
>> Should I post a new message with the patch to ffmpeg-devel at ffmpeg.org list?
>> ffplay.c | 52 +++++++++++++++++++++++++++++++++++++---------------
>> 1 file changed, 37 insertions(+), 15 deletions(-)
>> b7142d62e8a61dcd04b9cbc1c6c847918fea438a 0001-Add-FFplay-progress-bar-feature.patch
>> From e780cfa4330ae87cd4506ec2ccfe39ea045f2134 Mon Sep 17 00:00:00 2001
>> From: Ray Pierce <ray1110000 at yandex.com>
>> Date: Thu, 13 Apr 2017 20:41:59 +0500
>> Subject: [PATCH] Add FFplay progress bar feature
> whats the status of this ?
I've tested it, LGTM, but need modify the patch to newest version of
code. because the new version of ffplay.c is moved to fftools
and need add documentation .
> (just noticed this doesnt apply anymore)
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> Breaking DRM is a little like attempting to break through a door even
> though the window is wide open and the only thing in the house is a bunch
> of things you dont want and which you would get tomorrow for free anyway
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel