[FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

[Carl Eugen Hoyos]

2017-11-06 15:09 GMT+01:00 Ronald S. Bultje <rsbultje at gmail.com>:
> Hi,
>
> On Mon, Nov 6, 2017 at 8:21 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
>> 2017-11-06 13:52 GMT+01:00 Ronald S. Bultje <rsbultje at gmail.com>:

>> > Split, and pushed.
>>
>> +    format = (char *) s->desc->name;
>>
>> Isn't this cast a bad idea?
>
> It's an API thing. We can either strdup(), or use a cast, or have a
> compiler warning.

Yes.

> libvmaf does not modify the argument even if it doesn't
> use const here.

I hoped (and assumed) so.

What I meant was:
It is one thing to know that within FFmpeg, we do not modify
a pointer target and therefore decide to cast, but isn't it
another (bad) thing to assume this for an external library?

Carl Eugen