[FFmpeg-devel] [PATCH] lavu/timecode: clarify error msg for timecode_rate

[Michael Niedermayer]

On Sun, Nov 05, 2017 at 09:40:41PM +0530, Gyan Doshi wrote:
> Prompted by an issue reported at StackExchange, patch changes error
> message for timecode_rate values below 1.
> 
> The user-supplied value for timecode_rate in drawtext is rounded
> to nearest integer. So, a supplied value of 0.49 or lower is rounded
> to 0. This throws a misleading error message which says "Timecode
> frame rate must be specified". Changed message to account for values
> under one.
> 
> Also noted supported framerates for drop TC.
> 
> Regards,
> Gyan

>  doc/filters.texi     |    4 +++-
>  libavutil/timecode.c |    2 +-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 46ec36f411475b98d95396db7f239cb832fd80ae  0001-lavu-timecode-clarify-error-msg-for-timecode_rate.patch
> From ef152e77da4d1ea40d452b9cc86dcc51df1e20a7 Mon Sep 17 00:00:00 2001
> From: Gyan Doshi <gyandoshi at gmail.com>
> Date: Sun, 5 Nov 2017 21:29:22 +0530
> Subject: [PATCH] lavu/timecode: clarify error msg for timecode_rate
> 
> The user-supplied value for timecode_rate in drawtext is rounded
> to nearest integer. So, a supplied value of 0.49 or lower is rounded to 0.
> This throws a misleading error message which says "Timecode frame rate must be
> specified". Changed message to account for values under one.
> 
> Also noted supported framerates for drop TC.

will apply

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171110/a0ba0307/attachment.sig>