[FFmpeg-devel] [PATCH v4 06/14] avcodec: add decode_params callback to AVHWAccel struct

[Michael Niedermayer]

On Fri, Nov 10, 2017 at 01:40:51PM -0800, Aman Gupta wrote:
> From: Aman Gupta <aman at tmm1.net>
> 
> ---
>  libavcodec/avcodec.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index c4134424f0..2bd46faa50 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -3459,6 +3459,20 @@ typedef struct AVHWAccel {
>       */
>      int (*start_frame)(AVCodecContext *avctx, const uint8_t *buf, uint32_t buf_size);
>  
> +    /**
> +     * Callback for parameter data (SPS/PPS/VPS etc).
> +     *
> +     * Useful for hardware decoders which keep persistent state about the
> +     * video parameters, and need to receive any changes to update that state.
> +     *
> +     * @param avctx the codec context

> +     * @param type the parameter type

thats a bit terse
one couldnt use this with just this information.
is this the nal unit type ? if so then saying this would be clearer


> +     * @param buf the slice data buffer base
> +     * @param buf_size the size of the slice in bytes
> +     * @return zero if successful, a negative value otherwise
> +     */

> +    int (*decode_params)(AVCodecContext *avctx, int type, const uint8_t *buf, uint32_t buf_size);

uint32_t possibly should be something else, either unsigned or size_t

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171111/b8dd4fab/attachment.sig>