[FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Umair Khan omerjerk at gmail.com
Mon Nov 13 07:41:56 EET 2017


Hi,

On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 2017-11-12 20:30 GMT+01:00 Umair Khan <omerjerk at gmail.com>:
>> Hi,
>>
>> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>> 2017-11-12 20:05 GMT+01:00 Umair Khan <omerjerk at gmail.com>:
>>>
>>>> The attached patch fixes the address sanitizer issue.
>>>
>>> Breaks compilation here, how did you test?
>>>
>>> libavcodec/alsdec.c: In function ‘decode_var_block_data’:
>>> libavcodec/alsdec.c:938:7: error: expected ‘}’ before ‘else’
>>
>> Sorry for the faulty patch. Here is the fixed one.
>
> The commit message of your patch is:
> libavcodec/als: fix address sanitization error in decoder
>
> Is there an error in current FFmpeg git head that asan
> shows? If not, the commit message makes no sense.
>
> I believe you should send two patches that are meant
> to be committed together, one of them fixing ticket #6297.

This is the complete patchset.

-Umair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libavcodec-als-remove-check-for-predictor-order-of-a.patch
Type: application/octet-stream
Size: 956 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171113/9a0e79c2/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-libavcodec-als-fix-address-sanitization-error-in-dec.patch
Type: application/octet-stream
Size: 863 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171113/9a0e79c2/attachment-0001.obj>


More information about the ffmpeg-devel mailing list