[FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

[James Almer]

On 11/15/2017 10:35 PM, Carl Eugen Hoyos wrote:
> 2017-11-16 2:29 GMT+01:00 James Almer <jamrial at gmail.com>:
> 
>> The OP configure line is a massive dump of pointless
>> "--disable" options typical from Gentoo builds,
> 
> Good to know we agree on something.
> 
>> so i didn't even bother looking at it for specific things.
> 
>> And now that i look at yours they are completely different
>> as well
> 
> And I thought I spent several hours today only to allow you
> to reproduce a crash to ease testing by providing the
> necessary configure switches.
> They are of course identical to what the op provided, do
> you really suggest I added those stupidities for fun?

Yours was "--enable-small --toolchain=hardened --disable-avx", and only
the latter is in the OP configure line. They didn't use neither small or
hardened.

At no point i tried to offend you in any way. I did not care about the
configure line from OP as it was a mess, and did not even get to look at
yours since after checking what you reported as the first bad commit
(Making proresdec2 use the other decoder's DSP) it was clear to me that
said commit did not bother making sure the buffers were aligned for simd
optimizations, even if i couldn't reproduce it.

Sorry for any misunderstanding.

> 
>> so perhaps it doesn't depend on configure options but
>> something else, like target.
> 
> Yes, the issue is only reproducible on x86-64.
> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>