[FFmpeg-devel] [PATCH 1/6] decklink: Fix case where return value wasn't being set before checked for errors

Devin Heitmueller dheitmueller at ltnglobal.com
Thu Nov 16 20:34:12 EET 2017


I missed an assignement which cauesd the error case to not ever be properly
checked.

Signed-off-by: Devin Heitmueller <dheitmueller at ltnglobal.com>
---
 libavdevice/decklink_enc.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp
index 070bfad..1fb986e 100644
--- a/libavdevice/decklink_enc.cpp
+++ b/libavdevice/decklink_enc.cpp
@@ -300,7 +300,7 @@ static int decklink_construct_vanc(AVFormatContext *avctx, struct decklink_ctx *
         if (ret != 0)
             return AVERROR(ENOMEM);
 
-        klvanc_set_framerate_EIA_708B(pkt, ctx->bmd_tb_num, ctx->bmd_tb_den);
+        ret = klvanc_set_framerate_EIA_708B(pkt, ctx->bmd_tb_num, ctx->bmd_tb_den);
         if (ret != 0) {
             av_log(avctx, AV_LOG_ERROR, "Invalid framerate specified: %lld/%lld\n",
                    ctx->bmd_tb_num, ctx->bmd_tb_den);
-- 
1.8.3.1



More information about the ffmpeg-devel mailing list