[FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

Michael Niedermayer michael at niedermayer.cc
Mon Nov 20 22:40:44 EET 2017


On Mon, Nov 20, 2017 at 12:05:05PM -0800, Dale Curtis wrote:
> On Sat, Nov 18, 2017 at 2:44 AM, Michael Niedermayer <michael at niedermayer.cc
> > wrote:
> >
> > this would skip the code for wrap_bits >= 63, this does not look
> > correct
> >
> 
> Why do you think that's incorrect? The max int64_t value is 1 << 63 and 2
> << 63 == 1 << 64 ?

I think its incorrect because the change would completely skip the loop
but a wrap of "1<<64" would still need pts to be filled in.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171120/a6336fdd/attachment.sig>


More information about the ffmpeg-devel mailing list