[FFmpeg-devel] [PATCH] avfilter: add normalize filter

[Moritz Barsnick]

On Tue, Nov 21, 2017 at 21:45:00 +1100, Richard Ling wrote:
> Updated patch.

Nice. I personally appreciate your code comments, as I'm no big filter
author (yet).

>  doc/filters.texi           |  80 ++++++++++
>  libavfilter/Makefile       |   1 +
>  libavfilter/allfilters.c   |   1 +
>  libavfilter/vf_normalize.c | 389 +++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 471 insertions(+)

I *believe* adding a new filter requires a Changelog entry and a
version bump, but the filter maintainers will confirm that.

> +#define MAX_HISTORY_LEN     0x10000

Unused?

> +// This function is the main guts of the filter. Normalizes the input frame

Isn't "gut" the singular form? SCNR ;-)

> +    if (s->history_mem != NULL)
> +        av_free(s->history_mem);

No NULL check necessary, see av_free() docs.

I can't say much about the rest, leaving that to others.

Moritz