[FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert

Michael Niedermayer michael at niedermayer.cc
Wed Nov 22 22:09:09 EET 2017


On Wed, Nov 22, 2017 at 02:09:46PM +0000, Derek Buitenhuis wrote:
> On 11/22/2017 12:04 PM, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/mov.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> If it's a duplicate check, is there even a gain from using an assert?

not much, no
its a non static function tough
i can remove the check completely if thats preferred ?


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171122/926bde3f/attachment.sig>


More information about the ffmpeg-devel mailing list