[FFmpeg-devel] [PATCH] avfilter: add lv2 wrapper filter

Paul B Mahol onemda at gmail.com
Sat Nov 25 18:10:28 EET 2017


On 11/24/17, Paul B Mahol <onemda at gmail.com> wrote:
> On 11/24/17, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
>> On 11/23/2017 9:16 PM, Paul B Mahol wrote:
>>
>>> +typedef struct LV2Context {
>>> +    const AVClass *class;
>>> +    char *plugin_uri;
>>> +    char *options;
>>> +
>>> +    unsigned long nb_inputs;
>>> +    unsigned long nb_inputcontrols;
>>> +    unsigned long nb_outputs;
>>
>> Why are you using longs instead of stdint?
>
> Fixed.
>
>>
>>> +    table->uris = av_realloc(table->uris, ++table->n_uris *
>>> sizeof(char*));
>>> +    table->uris[table->n_uris - 1] = av_malloc(len + 1);
>>
>> Every single allocation in this whole file is completely unchecked.
>> That's
>> not OK.
>
> Fixed.
>

If there are no more comments, I would like to apply this.


More information about the ffmpeg-devel mailing list