[FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

Ronald S. Bultje rsbultje at gmail.com
Mon Sep 4 04:27:53 EEST 2017


On Sun, Sep 3, 2017 at 7:54 PM, Michael Niedermayer <michael at niedermayer.cc>

> Its unprofessional to fail decoding a file but not provide any
> hint as to why a failure occured.

> Our code is already quite terse and devoid of comments and
> documentation, error messages do not seem a exception here

Both of these comments assume the error message that you're trying to add
is in any shape, way or form helpful to end users.

Unfortunately, it is not.

Imagine that j-b saw the error message (compared to the generic "invalid
data") and ask yourself if the utility was any different (again, compared
to the generic "invalid data"). If not, then it shouldn't be an
AV_LOG_ERROR message displayed to end users.


More information about the ffmpeg-devel mailing list