[FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

Michael Niedermayer michael at niedermayer.cc
Mon Sep 4 21:16:20 EEST 2017

On Mon, Sep 04, 2017 at 02:36:45PM -0300, James Almer wrote:
> On 9/4/2017 2:23 PM, wm4 wrote:
> > On Mon,  4 Sep 2017 18:11:44 +0200
> > Michael Niedermayer <michael at niedermayer.cc> wrote:
> > 
> >> Fixes: Timeout
> >> Fixes: 3142/clusterfuzz-testcase-5007853163118592
> >>
> >> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> >> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > 
> > Wasn't this patch rejected before?
> Ronald rejected the previous version because of the obscure error
> messages. I suggested an alternative and Michael sent a new patch
> following it.
> If this is also not ok then please say so. That way the error messages
> can be removed before pushing the patch and we can go back to focus on
> things worth discussing.

> > 
> > Can't we just remove this codec? It has no use other than causing
> > potential security issues and maintenance.
> I agree about removing the encoder, but the decoder is needed for
> existing streams. Unless everyone just argues it has no real world
> samples for being an avcodec-only toy codec.
> If you send a patch removing the encoder without also trying to remove
> all the things that currently depend on it (One or two filters i think)
> then I'll +1 it. ffv1 and mpeg4 encoders are enough for any kind of
> testing, fate or otherwise, that might require a native encoder.

I find it a bit offensive that people suggest to remove the encoder i

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170904/8d4aa506/attachment.sig>

More information about the ffmpeg-devel mailing list