[FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

Jeyapal, Karthick kjeyapal at akamai.com
Tue Sep 5 14:27:02 EEST 2017

>On 9/3/17, 8:19 PM, "Marton Balint" <cus at passwd.hu<mailto:cus at passwd.hu>> wrote:

>Why don't use you simply use uint16_t here as well? I think we typically
>try to avoid unsigned as a type.
Done. Changed it to uint16_t.

>This VANC parser does not seem right. VANC header can appear multiple
>times, you seem to parse only the first DID. Also, you should simply
>ignore unknown DID-s, ffmpeg will not be able to parse all types there
>are, there is no need to warn.
Thanks for pointing it out. Have handled it now. Also changed the warning log to debug log.

Please find the patch attached.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-avdevice-decklink_dec-Added-Closed-caption-decode-fr.patch
Type: application/octet-stream
Size: 9768 bytes
Desc: 0003-avdevice-decklink_dec-Added-Closed-caption-decode-fr.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170905/3902152b/attachment.obj>

More information about the ffmpeg-devel mailing list