[FFmpeg-devel] [PATCHv6 2/2] avcodec/vp9: Add tile threading support

[Ronald S. Bultje]

Hi,

On Tue, Sep 5, 2017 at 7:59 PM, Ilia Valiakhmetov <zakne0ne at gmail.com>
wrote:

> Signed-off-by: Ilia Valiakhmetov <zakne0ne at gmail.com>
>
> v6 with changes from Ronald(BBB):
> ---
>  libavcodec/vp9.c             | 664 ++++++++++++++++++++++++++++++
> -------------
>  libavcodec/vp9_mc_template.c | 202 ++++++-------
>  libavcodec/vp9block.c        | 522 ++++++++++++++++------------------
>  libavcodec/vp9dec.h          | 103 ++++---
>  libavcodec/vp9mvs.c          |  97 ++++---
>  libavcodec/vp9prob.c         |  64 ++---
>  libavcodec/vp9recon.c        | 153 +++++-----
>  7 files changed, 1050 insertions(+), 755 deletions(-)


I don't have any further comments, all my comments were addressed in this
patch (make cross-thread signaling functions static, some fixed to prevent
a race condition, some memory usage reductions). I've tested a fair bit and
I don't think there's any speed/memory regressions with frame threading (or
w/o threading), and the new tile threading seems stable and race-free.

I'll leave this out for review for other people if anyone wants, and if
there's no other responses by tomorrow, I'll push it.

Ronald