[FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

Ronald S. Bultje rsbultje at gmail.com
Wed Sep 6 20:52:29 EEST 2017


On Wed, Sep 6, 2017 at 10:33 AM, James Almer <jamrial at gmail.com> wrote:

> But i also agree with him that, currently, the
> tree is littered with error messages that go "$spec_field is out of
> range" or whatever, and that they have not been seen as an issue before.
> He basically argues that wanting to make new ones debug level is not
> consistent with the existing code, so the proper approach would be to
> change all of them to debug in the long run, or keep adding new ones as
> error (as long as they are at least understandable).

I'm happy to help replace them with ff_dlog() or remove them, for the sake
of resolving the "consistency" argument.

Why care now? I don't mind minor issues, our tree is littered with them,
but with the amount of changes Michael is making in this area, this isn't
"minor" anymore, and it's growing. It's better to resolve such issues
before it grows out of hand and we're stuck with another MpegEncContext or


More information about the ffmpeg-devel mailing list