[FFmpeg-devel] [PATCH 1/4] avdevice/decklink_dec: Added VANC search for all resolutions
cus at passwd.hu
Thu Sep 7 20:44:28 EEST 2017
On Tue, 5 Sep 2017, Jeyapal, Karthick wrote:
> Overlooked a “signed vs unsigned comparison” compilation warning in the previous patch. Sorry about that. Please use this updated patch(attached) for review.
Thanks, I think it is better if we parse all lines after the line
affected by switching, so I am suggesting these start lines:
480i: 11.. , 274..
576i: 7.., 320..
1080i: 8.., 570..
Also there is a condition in the code:
+ if (i == vanc_line_numbers[idx].field0_vanc_end)
+ i = vanc_line_numbers[idx].field1_vanc_start;
I think 'i' should be field1_vanc_start - 1, because the loop will
increase the value of i.
Otherwise the patch looks good.
More information about the ffmpeg-devel