[FFmpeg-devel] [PATCH] avfilter/vf_tonemap: don't use NAN constant as an initializer

Hendrik Leppkes h.leppkes at gmail.com
Fri Sep 8 12:53:52 EEST 2017


On Fri, Sep 8, 2017 at 10:25 AM, Nicolas George <george at nsup.org> wrote:
> Le primidi 21 fructidor, an CCXXV, James Almer a écrit :
>> What can we do, then? NAN and nan("") are sometimes compile-time
>> constants and sometimes not, apparently depending on build type and
>> target system.
>>
>> CCing Vittorio as he's the author of the filter.
>
> "The macro NAN is defined if and only if the implementation supports
> quiet NaNs for the float type. It expands to a constant expression of
> type float representing a quiet NaN."
>
> -> If the macro is defined, it must be a compile-time constant.
> Therefore, DJGPP is wrong.
>

So if it would not be defined at all, the filter would still not
build. So what exactly does that change?

- Hendrik


More information about the ffmpeg-devel mailing list