[FFmpeg-devel] [PATCH 12/14] lavfi: Add OpenCL overlay filter

James Almer jamrial at gmail.com
Mon Sep 11 21:18:01 EEST 2017

On 9/11/2017 2:29 PM, Nicolas George wrote:
> Le quintidi 25 fructidor, an CCXXV, James Almer a écrit :
>> Cleaner Makefile, removing a lot of repeated objects on every filter
>> dependency entry.
> If I understand correctly, it only moves the complexity from Makefile to
> configure. But configure and shell scripts are for what cannot be
> achieved simply with make; this can. For example, if a subsystem is made
> of several files, having configure enable all of them is simpler than
> having all the files as a dependency. But in this case there is only
> one.

Yes, it moves things to configure where many filters already have
assorted non lavfi dependencies listed there (fft, etc), so the end
result of having the Makefile listing only the filter specific file(s)
for each OBJS entry is IMO worth the change.

>> Is the idea that every filter will eventually use framesync2 in the long
>> run, or will it not be used by some?
> framesync(2) is for filters that have several video inputs that needs to
> get synchronous frames on them. So clearly not all filters.

Ok. Since you have a patchset removing framesync and renaming framesync2
I'll wait until that's committed before sending the aforementioned change.

More information about the ffmpeg-devel mailing list