[FFmpeg-devel] [PATCH] avfilter: add despill filter

Moritz Barsnick barsnick at gmx.net
Thu Sep 14 18:24:03 EEST 2017


On Mon, Aug 28, 2017 at 15:25:54 +0200, Paul B Mahol wrote:
> + at table @option
> + at item type
> +Set what type of despill to use.

Please add:
    Accepted values are @code{green} and @code{blue} for greenscreen and
    bluescreen spills.
(Or make this a list.)

> + at item mix
> +Set how spillmap will be generated.

This doesn't make it clear that it's a value (and defaults to 0.5).

> + at item red
> +Controls ammount of red in spill area.
            ^ amount
(Same remark for two further cases.)

> + at item green
> +Controls ammount of green in spill area.
> +Should be -1 for greenscreen.

Perhaps @code{-1}. Remark also valid for "blue".

> +    { "red",        "set red scale",           OFFSET(bluescale),   AV_OPT_TYPE_FLOAT,   {.dbl=0},  -100, 100, FLAGS },

Assigned to the wrong variable.

Cheers,
Moritz


More information about the ffmpeg-devel mailing list