[FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: Fix AV_OPT_TYPE_STRING handling in avctx

Michael Niedermayer michael at niedermayer.cc
Fri Sep 15 03:16:58 EEST 2017

On Wed, Sep 13, 2017 at 08:11:38PM +0200, Reimar Döffinger wrote:
> On Wed, Sep 13, 2017 at 07:12:48PM +0200, Reimar Döffinger wrote:
> > This is the equivalent to what 7d317d4706b49d572a1eb5269438753be18362c7
> > did for the codec-specific options.
> > av_opt_copy has specific handling so it's fine that we already copied
> > the whole context before.

the change looks reasonable

> Btw, if someone can make time for reviewing it that would likely
> be time well spent.

you mean reviewing the whole frame_thread_encoder code searching
for issues unrelated to tickets or patches ?
ATM i think i have too much i should have done "yesterday" to add that

> For example it seems the code also leaks the memory for the AVPacket
> it mallocs sometimes.

is there some way by which this can be reproduced or is it completely
random ?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170915/926b7b15/attachment.sig>

More information about the ffmpeg-devel mailing list