[FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

[Thierry Foucu]

On Fri, Sep 15, 2017 at 8:24 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com>
wrote:

> 2017-09-15 17:13 GMT+02:00 Thierry Foucu <tfoucu at gmail.com>:
>
> >> Too fast to reply again, my bad. It's indeed a GCC bug.
> >
> > Sorry about it. I'm glad you found the problem.
>
> I suspect the comment above only applies to the asan hang,
> a valgrind issue was also mentioned in this thread.
>
>
valgrind seems to work for me here:

valgrind ./ffmpeg -i fate-suite/qtrle/apple-animation-variable-fps-bug.mov
-vf fps=30 -pix_fmt yuv420p -f null -
VALGRIND_MEMORY_LIMIT_IN_MB=8192; VALGRIND_TIMEOUT=3600
==134036== Memcheck, a memory error detector
==134036== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.
==134036== Using Valgrind-3.9.0.SVN and LibVEX; rerun with -h for copyright
info
==134036== Command: ./ffmpeg -i
fate-suite/qtrle/apple-animation-variable-fps-bug.mov -vf fps=30 -pix_fmt
yuv420p -f null -
==134036==
ffmpeg version N-87233-ge59da0f7ff Copyright (c) 2000-2017 the FFmpeg
developers
  built with gcc 4.8 (Ubuntu 4.8.4-2ubuntu1~14.04.3)
  configuration:
  WARNING: library configuration mismatch
  avutil      configuration: --enable-nonfree --enable-gpl --enable-version3
  avcodec     configuration: --enable-nonfree --enable-gpl --enable-version3
  avformat    configuration: --enable-nonfree --enable-gpl --enable-version3
  avdevice    configuration: --enable-nonfree --enable-gpl --enable-version3
  avfilter    configuration: --enable-nonfree --enable-gpl --enable-version3
  swscale     configuration: --enable-nonfree --enable-gpl --enable-version3
  swresample  configuration: --enable-nonfree --enable-gpl --enable-version3
  libavutil      55. 74.100 / 55. 74.100
  libavcodec     57.105.100 / 57.105.100
  libavformat    57. 81.100 / 57. 81.100
  libavdevice    57.  8.100 / 57.  8.100
  libavfilter     6.103.100 /  6.103.100
  libswscale      4.  7.103 /  4.  7.103
  libswresample   2.  8.100 /  2.  8.100
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from
'fate-suite/qtrle/apple-animation-variable-fps-bug.mov':
  Metadata:
    major_brand     : qt
    minor_version   : 537199360
    compatible_brands: qt
    creation_time   : 2012-07-27T07:09:56.000000Z
  Duration: 00:00:02.93, start: 0.000000, bitrate: 58 kb/s
    Stream #0:0(eng): Video: qtrle (rle  / 0x20656C72), rgb24, 112x182, 55
kb/s, 1.69 fps, 30 tbr, 3k tbn, 3k tbc (default)
    Metadata:
      creation_time   : 2012-07-27T07:09:56.000000Z
      handler_name    : Apple Alias Data Handler
      encoder         : Animation
Stream mapping:
  Stream #0:0 -> #0:0 (qtrle (native) -> wrapped_avframe (native))
Press [q] to stop, [?] for help
Output #0, null, to 'pipe:':
  Metadata:
    major_brand     : qt
    minor_version   : 537199360
    compatible_brands: qt
    encoder         : Lavf57.81.100
    Stream #0:0(eng): Video: wrapped_avframe, yuv420p, 112x182, q=2-31, 200
kb/s, 30 fps, 30 tbn, 30 tbc (default)
    Metadata:
      creation_time   : 2012-07-27T07:09:56.000000Z
      handler_name    : Apple Alias Data Handler
      encoder         : Lavc57.105.100 wrapped_avframe
frame=   88 fps=0.0 q=-0.0 Lsize=N/A time=00:00:02.93 bitrate=N/A
speed=3.35x
video:45kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB
muxing overhead: unknown
==134036==
==134036== HEAP SUMMARY:
==134036==     in use at exit: 140,670 bytes in 9 blocks
==134036==   total heap usage: 4,339 allocs, 4,330 frees, 3,453,256 bytes
allocated
==134036==
==134036== LEAK SUMMARY:
==134036==    definitely lost: 528 bytes in 1 blocks
==134036==    indirectly lost: 140,102 bytes in 7 blocks
==134036==      possibly lost: 0 bytes in 0 blocks
==134036==    still reachable: 40 bytes in 1 blocks
==134036==         suppressed: 0 bytes in 0 blocks
==134036== Rerun with --leak-check=full to see details of leaked memory
==134036==
==134036== For counts of detected and suppressed errors, rerun with: -v
==134036== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 1)



> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>