[FFmpeg-devel] [PATCH 1/2] avcodec/wmv2dec: Check end of bitstream in parse_mb_skip() and ff_wmv2_decode_mb()

Ronald S. Bultje rsbultje at gmail.com
Mon Sep 18 16:11:39 EEST 2017


Hi Michael,

On Sun, Sep 17, 2017 at 8:15 PM, Michael Niedermayer <michael at niedermayer.cc
> wrote:

> Iam happy to follow what the community prefers.
>

Some don't like it, some don't care. I think everyone would be happy (and
thus the sum of happiness would increase) if you changed this to ff_dlog()
or something along those lines.

You say you want to code, so why not take the path of least resistance and
move on? Is this just about being right? Or do you really believe it's
important to display an error message while fuzzing? Or do you have actual
evidence that this is an error path that will often occur in real-world
files and where the provided error message helps our users resolve the
issue that their valid (non-fuzzed, real-world) file is not playing back? I
don't understand.

Ronald


More information about the ffmpeg-devel mailing list