[FFmpeg-devel] [PATCH 2/2] pngdec: expose gAMA and cHRM chunks as AVMasteringDisplayMetadata

James Almer jamrial at gmail.com
Wed Sep 20 21:22:42 EEST 2017


On 9/20/2017 3:18 PM, wm4 wrote:
> On Wed, 20 Sep 2017 04:00:28 +0100
> Rostislav Pehlivanov <atomnuker at gmail.com> wrote:
> 
>> +    if (mdm.has_gamma || mdm.has_primaries) {
>> +        AVMasteringDisplayMetadata *new_mdm = av_mastering_display_metadata_create_side_data(p);
>> +        memcpy(new_mdm, &mdm, sizeof(AVMasteringDisplayMetadata));
>> +    }
>> +
> 
> Use assignment instead of memcpy, duh.

He shouldn't be using AVMasteringDisplayMetadata on stack to begin with,
so no.

It's bad enough sizeof() has to be used at all already.


More information about the ffmpeg-devel mailing list