[FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

Carl Eugen Hoyos ceffmpeg at gmail.com
Wed Apr 4 04:33:55 EEST 2018

2018-04-03 7:58 GMT+02:00, Mattias Amnefelt <mattiasa at avm.se>:
> Yes, my feeling was also that it's better to handle this when possible.
> You are of course correct that the two tags needs to be inbetween
> frames. Sorry about that, I stripped the sample down too much. I updated
> with a sample which has two frames. This new sample fails the test
> without the patch.

> +fate-adts-id3v2-two-tags-demux: CMD = framecrc -f aac -i $(TARGET_SAMPLES)/aac/id3v2_two_tags.aac -c:a copy

The "-f aac" looks like a bad idea to me.
It's also true for the tests above, but that's still not reason to
add more.

Please avoid top-posting here, Carl Eugen

More information about the ffmpeg-devel mailing list