[FFmpeg-devel] avfilter/showvolume : add new options and minor clean

[Martin Vignali]

2018-03-31 16:21 GMT+02:00 Martin Vignali <martin.vignali at gmail.com>:

> Hello,
>
> In attach new patchs for showvolume filter
>
> 001 : Move the clear picture part to a new func, and use it if fade option
> == 0.
> (no need to calculate it in float)
>
> 002/003 : Move "height" condition for draw volume at the start of the loop
> and indent
>
> 004 : add a new option for choosing the display scale
> currently, the filter use linear display,
> most audio meter use some kind of log display
>
>
> 005 : WIP :
> The idea is to add an option to draw a line for the max level for a given
> duration.
> Several audio meter have this kind of display, and its help user, to check
> peak level (even
> if the "peak" happen during a very short time.
>
> I'm not entirely sure, this is the best way to add this.
>
> For now, i store the max value for each channel, update it, if a new peak
> is bigger than the store value
> And count the number of frame for display. If a given display duration is
> exceed, update the max value to the current max value.
>
> Missing docs and probably code reorganization to reduce code duplication.
>
> I also have had very few inspiration for option naming and variable naming
> (and i don't know the "official name" of this little line in audio meter).
> So i'm open to better naming suggestion.
>
> This display need to be enable using dm=1
> and the duration during the max value is still display can be set with
> dm_duration (in seconds)
>
>
Ping for patch 004 and 005

Martin