[FFmpeg-devel] [PATCH 1/4] lavf/aviobuf: add ff_get_chomp_line

[Marton Balint]

On Wed, 11 Apr 2018, Jun Zhao wrote:

>
>
> On 2018/4/10 21:54, Marton Balint wrote:
>>
>>
>> On Tue, 10 Apr 2018, Jun Zhao wrote:
>>
>>>
>>>
>>
>> Maybe you should use ff_read_line_to_bprint instead? It already chops
>> the trailing line endings, not any whitespace though. Generally I
>> think we should deprecate ff_get_line, because line length limits
>> always pop here or there...
>>
> ff_read_line_to_bprint usually use when we don't know the length limits
> and need to the caller free the AVBPrint resource, in hls case, I think
> this is a simple case, the other reason is I don't want to mix the
> AVBPrint and c native char * in hls. Thanks.

Since it's just factorization of existing code, then I guess it is OK.

But new code should not use either that or ff_get_line. (MAX_URL_SIZE 
being 4096 does not even adhere to the RFC recommendation of supporting at 
least 8000 char length URLs)

https://tools.ietf.org/html/rfc7230#section-3.1.1

Regards,
Marton