[FFmpeg-devel] [PATCH v3 01/11] avformat/dashenc: replacing 'min_seg_duration' with 'seg_duration'

Dixit, Vishwanath vdixit at akamai.com
Thu Apr 12 07:31:11 EEST 2018

On 4/11/18 11:47 PM, Carl Eugen Hoyos wrote:
> 2018-04-11 9:00 GMT+02:00, vdixit at akamai.com <vdixit at akamai.com>:
>> +    { "min_seg_duration", "minimum segment duration (in microseconds) (will
>> be deprecated)"
> "is deprecated"
> But since this is a user option added after the last release, you
> may also choose to simply delete it if this simplifies the code.
Thanks for your review inputs. Could you please clarify the comment? Do you mean, the option 'min_seg_duration' was added after the last stable release ffmpeg-3.4.2?
But, it looks like the option 'min_seg_duration' was added 4 years ago, much earlier than the couple of last stable releases. Please correct me if I am wrong.

> Otoh: Your commit message is missing an explanation why
> renaming this option is a good idea.
Sure. I will submit a new version of this patch with the explanation in the commit message.
> Carl Eugen

More information about the ffmpeg-devel mailing list