[FFmpeg-devel] [PATCH v2 1/3] avformat/vpcc: Calculate VP9 level from Luma's Sample rate and Picture size

Ronald S. Bultje rsbultje at gmail.com
Mon Apr 23 14:58:05 EEST 2018


On Mon, Apr 23, 2018 at 2:10 AM, Karthick J <kjeyapal at akamai.com> wrote:

> -    int level = par->level == FF_LEVEL_UNKNOWN ? 0 : par->level;
> +    int level = par->level == FF_LEVEL_UNKNOWN ?
> +        get_vp9_level(par, frame_rate) : par->level;

After this change, how will I create a file without a level?

This patch blurs the line between "unknown", "unspecified", "non-existent"
and "autodetect". Linguistically, each of these mean something
fundamentally different. I think it's acceptable to not have too many ways
of specifying something which in practice comes down to "nope", but you're
removing the "nope" altogether, which isn't quite right either.


More information about the ffmpeg-devel mailing list