[FFmpeg-devel] [PATCH 2/3] avcodec/mpeg4video_parser: Fix incorrect spliting of MPEG-4 studio frames

Michael Niedermayer michael at niedermayer.cc
Mon Apr 30 19:18:19 EEST 2018


On Sun, Apr 29, 2018 at 11:22:42PM +0000, Kieran Kunhya wrote:
> On Sun, 29 Apr 2018 at 22:57 Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/mpeg4video_parser.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/libavcodec/mpeg4video_parser.c
> > b/libavcodec/mpeg4video_parser.c
> > index b7d6da1f75..453d373e6e 100644
> > --- a/libavcodec/mpeg4video_parser.c
> > +++ b/libavcodec/mpeg4video_parser.c
> > @@ -61,6 +61,8 @@ int ff_mpeg4_find_frame_end(ParseContext *pc, const
> > uint8_t *buf, int buf_size)
> >          for (; i < buf_size; i++) {
> >              state = (state << 8) | buf[i];
> >              if ((state & 0xFFFFFF00) == 0x100) {
> > +                if (state == 0x1B7 || state == 0x1B8)
> > +                    continue;
> >                  pc->frame_start_found = 0;
> >                  pc->state             = -1;
> >                  return i - 3;
> > --
> >
> 
> Add a comment explaining what you are doing here please.

will use named constants to make this more clear

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Modern terrorism, a quick summary: Need oil, start war with country that
has oil, kill hundread thousand in war. Let country fall into chaos,
be surprised about raise of fundamantalists. Drop more bombs, kill more
people, be surprised about them taking revenge and drop even more bombs
and strip your own citizens of their rights and freedoms. to be continued
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180430/d900bf73/attachment.sig>


More information about the ffmpeg-devel mailing list