[FFmpeg-devel] [PATCH 1/2] avformat/movenc: Added an option to disable SIDX atom

[Tobias Rapp]

On 04.12.2018 09:41, Karthick J wrote:
> ---
>   doc/muxers.texi      | 2 ++
>   libavformat/movenc.c | 7 +++++--
>   libavformat/movenc.h | 1 +
>   3 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index f1cc6f5fee..6ca27b04a3 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -1325,6 +1325,8 @@ more efficient), but with this option set, the muxer writes one moof/mdat
>   pair for each track, making it easier to separate tracks.
>   
>   This option is implicitly set when writing ismv (Smooth Streaming) files.
> + at item -movflags no_sidx
> +Don't write sidx atom.
>   @item -movflags faststart
>   Run a second pass moving the index (moov atom) to the beginning of the file.
>   This operation can take a while, and will not work in various situations such

What about naming the option "skip_sidx" for symmetry with the existing 
"skip_trailer"? Just my personal thought.

Also it might be worth mentioning in the docs how global_sidx and the 
new option correlate (which one is preferred if both exists, or is it an 
error to specify both?).

 >
 > [...]
 >
> diff --git a/libavformat/movenc.h b/libavformat/movenc.h
> index fe605d1ad2..ee6749bce2 100644
> --- a/libavformat/movenc.h
> +++ b/libavformat/movenc.h
> @@ -257,6 +257,7 @@ typedef struct MOVMuxContext {
>   #define FF_MOV_FLAG_SKIP_TRAILER          (1 << 18)
>   #define FF_MOV_FLAG_NEGATIVE_CTS_OFFSETS  (1 << 19)
>   #define FF_MOV_FLAG_FRAG_EVERY_FRAME      (1 << 20)
> +#define FF_MOV_FLAG_NO_SIDX               (1 << 21)
>   
>   int ff_mov_write_packet(AVFormatContext *s, AVPacket *pkt);
>   
> 

Regards,
Tobias