[FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

[Michael Niedermayer]

On Wed, Dec 05, 2018 at 06:52:06PM +0100, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavcodec/proresdec2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

breaks 
make fate-prores-alpha_skip
TEST    prores-alpha_skip
--- ./tests/ref/fate/prores-alpha_skip	2018-12-04 23:28:22.177830519 +0100
+++ tests/data/fate/prores-alpha_skip	2018-12-05 20:27:52.523422579 +0100
@@ -3,5 +3,5 @@
 #codec_id 0: rawvideo
 #dimensions 0: 1920x1080
 #sar 0: 0/1
-0,          0,          0,        1, 12441600, 0x65e009b8
-0,          1,          1,        1, 12441600, 0x65e009b8
+0,          0,          0,        1, 12441600, 0xf06f2ff5
+0,          1,          1,        1, 12441600, 0xf06f2ff5
Test prores-alpha_skip failed. Look at tests/data/fate/prores-alpha_skip.err for details.
make: *** [fate-prores-alpha_skip] Error 1

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181205/95f29b07/attachment.sig>