[FFmpeg-devel] [PATCH v3] avformat/movenc: Added an option to disable SIDX atom

[Tobias Rapp]

On 06.12.2018 06:07, Karthick J wrote:
> ---
>   doc/muxers.texi      |  4 ++++
>   libavformat/movenc.c | 12 ++++++++++--
>   libavformat/movenc.h |  1 +
>   3 files changed, 15 insertions(+), 2 deletions(-)
> 
> [...]
>   
> @@ -6067,6 +6070,11 @@ static int mov_init(AVFormatContext *s)
>           s->flags &= ~AVFMT_FLAG_AUTO_BSF;
>       }
>   
> +    if (mov->flags & FF_MOV_FLAG_GLOBAL_SIDX && s->flags & FF_MOV_FLAG_SKIP_SIDX) {
> +        av_log(s, AV_LOG_WARNING, "Global SIDX enabled; Ignoring skip_sidx option\n");
> +        mov->flags &= ~FF_MOV_FLAG_SKIP_SIDX;
> +    }
> +

There is still one use of s->flags instead of mov->flags, that should be 
changed.

>       if (mov->flags & FF_MOV_FLAG_FASTSTART) {
>           mov->reserved_moov_size = -1;
>       }
> diff --git a/libavformat/movenc.h b/libavformat/movenc.h
> index fe605d1ad2..68d6f23a5a 100644
> --- a/libavformat/movenc.h
> +++ b/libavformat/movenc.h
> @@ -257,6 +257,7 @@ typedef struct MOVMuxContext {
>   #define FF_MOV_FLAG_SKIP_TRAILER          (1 << 18)
>   #define FF_MOV_FLAG_NEGATIVE_CTS_OFFSETS  (1 << 19)
>   #define FF_MOV_FLAG_FRAG_EVERY_FRAME      (1 << 20)
> +#define FF_MOV_FLAG_SKIP_SIDX             (1 << 21)
>   
>   int ff_mov_write_packet(AVFormatContext *s, AVPacket *pkt);
>   
> 

Regards,
Tobias