[FFmpeg-devel] [PATCH 4/4] avformat/mxfenc: allow muxing prores

[Baptiste Coudurier]

On Thu, Dec 6, 2018 at 7:45 AM Paul B Mahol <onemda at gmail.com> wrote:

> On 12/6/18, Baptiste Coudurier <baptiste.coudurier at gmail.com> wrote:
> > Hi Paul,
> >
> > On Wed, Dec 5, 2018 at 3:18 PM Paul B Mahol <onemda at gmail.com> wrote:
> >
> >> On 12/6/18, Baptiste Coudurier <baptiste.coudurier at gmail.com> wrote:
> >> > Hi Paul
> >> >
> >> > On Wed, Dec 5, 2018 at 9:52 AM Paul B Mahol <onemda at gmail.com> wrote:
> >> >
> >> >> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> >> >> ---
> >> >>  libavformat/mxfenc.c | 49
> ++++++++++++++++++++++++++++++++++++++++++++
> >> >>  1 file changed, 49 insertions(+)
> >> >>
> >> >> [...]
> >> >>
> >> >> +static int mxf_parse_prores_frame(AVFormatContext *s, AVStream *st,
> >> >> AVPacket *pkt)
> >> >> +{
> >> >> +    MXFContext *mxf = s->priv_data;
> >> >> +    MXFStreamContext *sc = st->priv_data;
> >> >> +    int i, profile;
> >> >> +
> >> >> +    if (mxf->header_written)
> >> >> +        return 1;
> >> >> +
> >> >> +    sc->codec_ul = NULL;
> >> >> +    profile = st->codecpar->profile;
> >> >>
> >> >
> >> > We should fetch the profile from the bitstream.
> >> >
> >>
> >> AFAIK profile is not stored in it.
> >>
> >
> > Right. My thinking is how would this work going from MOV to MXF ? Or
> would
> > it work when encoding ?
>
> It works when encoding and stream copying, last time I tried.
>

After looking at the code, it seems like it would work assuming essence
comes from MXF or MOV,
raw would not work though but we can accept that.

So I think the patch is fine, as well as the demuxer one, could you please
apply the demuxer one first ?

Thanks!

-- 
Baptiste